Catalog
obra/requesting-code-review

obra

requesting-code-review

Use when completing tasks, implementing major features, or before merging to verify work meets requirements

global
0installs0uses~721
v1.0Saved May 2, 2026

Requesting Code Review

Dispatch superpowers:code-reviewer subagent to catch issues before they cascade. The reviewer gets precisely crafted context for evaluation — never your session's history. This keeps the reviewer focused on the work product, not your thought process, and preserves your own context for continued work.

Core principle: Review early, review often.

When to Request Review

Mandatory:

  • After each task in subagent-driven development
  • After completing major feature
  • Before merge to main

Optional but valuable:

  • When stuck (fresh perspective)
  • Before refactoring (baseline check)
  • After fixing complex bug

How to Request

1. Get git SHAs:

BASE_SHA=$(git rev-parse HEAD~1)  # or origin/main
HEAD_SHA=$(git rev-parse HEAD)

2. Dispatch code-reviewer subagent:

Use Task tool with superpowers:code-reviewer type, fill template at code-reviewer.md

Placeholders:

  • {WHAT_WAS_IMPLEMENTED} - What you just built
  • {PLAN_OR_REQUIREMENTS} - What it should do
  • {BASE_SHA} - Starting commit
  • {HEAD_SHA} - Ending commit
  • {DESCRIPTION} - Brief summary

3. Act on feedback:

  • Fix Critical issues immediately
  • Fix Important issues before proceeding
  • Note Minor issues for later
  • Push back if reviewer is wrong (with reasoning)

Example

[Just completed Task 2: Add verification function]

You: Let me request code review before proceeding.

BASE_SHA=$(git log --oneline | grep "Task 1" | head -1 | awk '{print $1}')
HEAD_SHA=$(git rev-parse HEAD)

[Dispatch superpowers:code-reviewer subagent]
  WHAT_WAS_IMPLEMENTED: Verification and repair functions for conversation index
  PLAN_OR_REQUIREMENTS: Task 2 from docs/superpowers/plans/deployment-plan.md
  BASE_SHA: a7981ec
  HEAD_SHA: 3df7661
  DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types

[Subagent returns]:
  Strengths: Clean architecture, real tests
  Issues:
    Important: Missing progress indicators
    Minor: Magic number (100) for reporting interval
  Assessment: Ready to proceed

You: [Fix progress indicators]
[Continue to Task 3]

Integration with Workflows

Subagent-Driven Development:

  • Review after EACH task
  • Catch issues before they compound
  • Fix before moving to next task

Executing Plans:

  • Review after each batch (3 tasks)
  • Get feedback, apply, continue

Ad-Hoc Development:

  • Review before merge
  • Review when stuck

Red Flags

Never:

  • Skip review because "it's simple"
  • Ignore Critical issues
  • Proceed with unfixed Important issues
  • Argue with valid technical feedback

If reviewer wrong:

  • Push back with technical reasoning
  • Show code/tests that prove it works
  • Request clarification

See template at: requesting-code-review/code-reviewer.md

Files2
2 files · 4.4 KB

Select a file to preview

Overall Score

82/100

Grade

B

Good

Safety

95

Quality

78

Clarity

85

Completeness

72

Summary

A coordination skill that guides agents to dispatch a code-reviewer subagent for structured peer review during development. It provides templates, timing guidance, and issue triage practices to catch defects early without disrupting the agent's working context.

Detected Capabilities

Git diff inspection and commit SHA extractionSubagent coordination and context isolationCode review template generation and populationIssue severity classification (Critical/Important/Minor)Production readiness assessment guidance

Trigger Keywords

Phrases that MCP clients use to match this skill to user intent.

code reviewbefore mergetask completionverify workquality checkissue feedbackproduction readiness

Risk Signals

INFO

Git operations (rev-parse, log, diff) used for safe metadata extraction

SKILL.md: How to Request section, code-reviewer.md: Git Range to Review
INFO

Subagent dispatch mechanism uses isolated context template to prevent prompt injection

SKILL.md: Dispatch code-reviewer subagent instruction
INFO

No destructive operations, credentials access, or external data transmission

All files

Use Cases

  • Request code review after completing a task in subagent-driven workflows
  • Get structured feedback before merging to main branch
  • Establish review discipline in AI-assisted development cycles
  • Triage review feedback and plan remediation by severity

Quality Notes

  • Excellent structure with clear mandatory vs. optional review triggers and decision tree for severity-based action
  • Concrete example workflow (Task 2 scenario) demonstrates end-to-end usage with realistic commit SHAs and feedback integration
  • Code reviewer template is thorough and actionable with specific checklist items (error handling, DRY, edge cases, security) and output format expectations
  • Strong emphasis on critical rules (specificity, severity calibration, verdict clarity) helps prevent common review antipatterns
  • Example output in code-reviewer.md provides exact format agents should emulate, with file:line references and structured issue categories
  • Red flags section (Never skip review, Never ignore Critical issues) establishes non-negotiable guardrails for development discipline
  • Weakness: code-reviewer.md template uses placeholder references ({PLAN_REFERENCE}) but does not explain how agents should resolve these paths in practice
  • Weakness: No guidance on how to handle large git diffs or how to scope reviews when commits span many files — could overwhelm the reviewer subagent
  • Missing edge case handling: What if BASE_SHA or HEAD_SHA are invalid? What if git diff output is empty or binary?
Model: claude-haiku-4-5-20251001Analyzed: May 2, 2026

Reviews

Add this skill to your library to leave a review.

No reviews yet

Be the first to share your experience.

Add obra/requesting-code-review to your library

Command Palette

Search for a command to run...