Catalog
obra/requesting-code-review

obra

requesting-code-review

Use when completing tasks, implementing major features, or before merging to verify work meets requirements

NewUpdated Oct 10, 2026

Requesting Code Review

Dispatch a code reviewer subagent to catch issues before they cascade. The reviewer gets precisely crafted context for evaluation — never your session's history.

Core principle: Review early, review often.

When to Request Review

Mandatory:

  • After each task in subagent-driven development
  • After completing major feature
  • Before merge to main

Optional but valuable:

  • When stuck (fresh perspective)
  • Before refactoring (baseline check)
  • After fixing complex bug

How to Request

1. Get git SHAs:

BASE_SHA=$(git rev-parse HEAD~1)  # or: git merge-base origin/main HEAD
HEAD_SHA=$(git rev-parse HEAD)

2. Dispatch code reviewer subagent:

Dispatch a general-purpose subagent, filling the template at code-reviewer.md

Placeholders:

  • {DESCRIPTION} - Brief summary of what you built
  • {PLAN_OR_REQUIREMENTS} - What it should do
  • {BASE_SHA} - Starting commit
  • {HEAD_SHA} - Ending commit

3. Act on feedback:

  • Fix Critical issues immediately
  • Fix Important issues before proceeding
  • Note Minor issues for later
  • Push back if reviewer is wrong (with reasoning)

Example

[Just completed Task 2: Add verification function]

You: Let me request code review before proceeding.

BASE_SHA=$(git log --oneline | grep "Task 1" | head -1 | cut -d' ' -f1)
HEAD_SHA=$(git rev-parse HEAD)

[Dispatch code reviewer subagent]
  DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types
  PLAN_OR_REQUIREMENTS: Task 2 from docs/superpowers/plans/deployment-plan.md
  BASE_SHA: a7981ec
  HEAD_SHA: 3df7661

[Subagent returns]:
  Strengths: Clean architecture, real tests
  Issues:
    Important: Missing progress indicators
    Minor: Magic number (100) for reporting interval
  Assessment: Ready to proceed

You: [Fix progress indicators]
[Continue to Task 3]

Common Rationalizations

Excuse Reality
"I'll just review the diff myself instead of dispatching a reviewer" You're the coordinator — reviewing the diff inline burns the context window you need to keep driving the work. Dispatch a reviewer subagent: the diff and the evaluation live in its context, and only the findings come back to you.
"The reviewer needs my whole session history to understand the change" Hand it precisely crafted context, never your session's history. That keeps the reviewer on the work product, not your thought process.

Red Flags

Never:

  • Skip review because "it's simple"
  • Ignore Critical issues
  • Proceed with unfixed Important issues
  • Argue with valid technical feedback

If reviewer wrong:

  • Push back with technical reasoning
  • Show code/tests that prove it works
  • Request clarification

See template at: code-reviewer.md

Files2
2 files · 7.3 KB

Select a file to preview

Overall Score

89/100

Grade

A

Excellent

Grades are signals, not a certification. Always review a skill yourself before use.

Safety

92

Quality

88

Clarity

87

Completeness

85

Summary

This skill teaches an agent when and how to request code review from a subagent during development. It provides a structured workflow for dispatching a reviewer with precisely scoped context (git diffs between two commits, requirements, and implementation summary), then acting on feedback by severity. The skill is coordination-focused, emphasizing that reviews happen early and often without burning the coordinator's context window.

Detected Capabilities

git command execution (rev-parse, log, diff, show, worktree)subagent dispatchcontext scoping and prompt templatingread-only code inspection

Trigger Keywords

Phrases that agents use to match this skill to user intent.

request code reviewcode review before mergedispatch reviewerreview git changesverify implementation against plan

Use Cases

  • Request code review after completing a task during subagent-driven development
  • Dispatch a reviewer before merging to main to catch issues early
  • Get a fresh perspective when stuck on a difficult implementation
  • Establish a baseline by reviewing code before starting refactoring
  • Verify complex bug fixes meet requirements and don't introduce regressions

Quality Notes

  • Excellent documentation of reviewer responsibilities with explicit 'Read-Only Review' section preventing mutations
  • Strong emphasis on context scoping — reviewer gets requirements and diffs, not session history
  • Clear severity calibration guide for issues (Critical / Important / Minor)
  • Includes realistic example walkthrough showing the full workflow end-to-end
  • Template provides concrete instructions on what reviewer should check (plan alignment, code quality, testing, production readiness)
  • Well-structured table of common rationalizations with direct counter-arguments
  • Specific git commands provided for SHA retrieval, reducing friction for adoption
  • Red flags section reinforces safety boundaries (never skip review for 'simple' changes, never ignore Critical issues)
  • Supporting template file (code-reviewer.md) is complete and internally consistent
Model: claude-haiku-4-5-20251001Analyzed: Oct 10, 2026

Reviews

Add this skill to your library to leave a review.

No reviews yet

Be the first to share your experience.

Version History

  1. v1.4

    Content updated

    ✦ AIReplaces awk with cut in git log example for extracting commit SHA.

    2026-10-10

    LATEST
  2. v1.3

    Content updated

    ✦ AIUpdates BASE_SHA git command to use merge-base for multi-branch workflows.

    2026-09-19

    View This Version
  3. v1.2

    Content updated

    ✦ AIRewrites guidance to emphasize isolated reviewer context and dispels common rationalizations for skipping code review.

    2026-09-09

    View This Version
  4. v1.1

    Content updated

    ✦ AIChanges subagent dispatch method from superpowers:code-reviewer to general-purpose type; refines template field names and review frequency.

    2026-06-28

    View This Version
  5. v1.0

    2026-05-02

    View This VersionInitial version

Use obra/requesting-code-review in your dev environment

Command Palette

Search for a command to run...